Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bevy_ecs::schedule::schedule module shares its name with its parent module #17344

Open
LikeLakers2 opened this issue Jan 13, 2025 · 0 comments
Open

The bevy_ecs::schedule::schedule module shares its name with its parent module #17344

LikeLakers2 opened this issue Jan 13, 2025 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@LikeLakers2
Copy link
Contributor

LikeLakers2 commented Jan 13, 2025 •
edited
Loading

While working on #17335, I came across bevy_ecs::schedule::schedule, which was linting clippy::module_inception.

I believe one module or the other should be renamed, as the current naming is confusing.
@BenjaminBrienen BenjaminBrienen added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LikeLakers2 @BenjaminBrienen