Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of bevy_ecs' tests lint on dependency_on_unit_never_type_fallback #17340

Open
LikeLakers2 opened this issue Jan 13, 2025 · 1 comment
Open

Some of bevy_ecs' tests lint on dependency_on_unit_never_type_fallback #17340

LikeLakers2 opened this issue Jan 13, 2025 · 1 comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Blocked This cannot move forward until something else changes

Comments

@LikeLakers2
Copy link
Contributor

I was asked by @BenjaminBrienen to make this issue, for tracking purposes.

bevy_ecs has this line near the top of its lib.rs, because some tests lint it:

bevy/crates/bevy_ecs/src/lib.rs

Lines 3 to 4 in 141b767

// TODO: remove once Edition 2024 is released
#![allow(dependency_on_unit_never_type_fallback)]

The lint attribute is meant to be removed once edition 2024 is released.
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Blocked This cannot move forward until something else changes labels Jan 13, 2025
@hymm
Copy link
Contributor

hymm commented Jan 14, 2025

We could make the file name plural schedules.rs, since the file also contains the definition for Schedules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Blocked This cannot move forward until something else changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LikeLakers2 @hymm @BenjaminBrienen