Fix double dialog export video #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
The code duplication is in a file that I've not modified, so we can ignore it. |
|
AUTOMERGE: (FAIL)
|
haslinghuis
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #516 that fixes #492
I don't like to add "manually" and patch the webm library, but it seems is the only solution at this moment.
In the original repo there is a discussion about how to real fix the problem: thenickdude/webm-writer-js#31 and a new issue with more information thenickdude/webm-writer-js#34 and a PR thenickdude/webm-writer-js#35 that does not seem that will be merged.
If someone has some time feel free to give a better solution to this.