Add RPM Debug with common scaling #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPM debug traces' curve min/max are calculated over all four debug fields. Thus when they are displayed on the same graph, they use the same scale.
mikeller
approved these changes
Feb 28, 2019
|
The only problem here is that we calculate the min/max values four times, one for each debug, but I think we can live with it. |
|
Yes, I was thinking of it also, but otherwise it would require some additional "caching" structures to see if the min max were already calculated, which I think would add more complexity to the code as a whole. These scales are only calculated when changing graphs, so there's no practical performance penalty. But if you think that such practice goes against the codelines of the project I can think of some caching mechanism. |
|
No, It was only a comment. As it is, is good enough. I will not change nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #196
It is useful to have the RPM traces on the same graph, because we can compare actual motor outputs when the same commands are given.
Curve scaling is implemented that calculates min/max over all four debug traces.