Update tests and fix uninitialized warnings for changes in SearchBuil…

…der 1.82 On Oracle, all not defined CLOB fields are set to NULL now, like VARCHAR.
bestpractical · Apr 25, 2024 · 78a0ba1 · 78a0ba1
1 parent a5b80f5
commit 78a0ba1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/lib/RT/Action/UserDefined.pm b/lib/RT/Action/UserDefined.pm
@@ -60,7 +60,7 @@ This happens on every transaction. it's always applicable
 
 sub Prepare {
     my $self = shift;
-    my $retval = eval $self->ScripObj->CustomPrepareCode;
+    my $retval = eval( $self->ScripObj->CustomPrepareCode // '' );
     if ($@) {
         $RT::Logger->error("Scrip ".$self->ScripObj->Id. " Prepare failed: ".$@);
         return (undef);
@@ -76,7 +76,7 @@ This happens on every transaction. it's always applicable
 
 sub Commit {
     my $self = shift;
-    my $retval = eval $self->ScripObj->CustomCommitCode;
+    my $retval = eval( $self->ScripObj->CustomCommitCode // '' );
     if ($@) {
         $RT::Logger->error("Scrip ".$self->ScripObj->Id. " Commit failed: ".$@);
         return (undef);

diff --git a/t/rest2/customfields.t b/t/rest2/customfields.t
@@ -56,6 +56,7 @@ my $freeform_cf_id;
         Type       => 'Freeform',
         LookupType => 'RT::Queue-RT::Ticket',
         MaxValues  => 1,
+        Pattern    => '(?#Mandatory).',
     };
     my $res = $mech->post_json("$rest_base_path/customfield",
         $payload,
@@ -157,7 +158,9 @@ my $freeform_cf_id;
     is($content->{MaxValues}, 1);
     is($content->{Disabled}, 0);
 
-    my @fields = qw(SortOrder Pattern Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    my @fields = qw(SortOrder Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    # Pattern is undef by default on Oralce and thus excluded from the response
+    push @fields, 'Pattern' unless RT->Config->Get('DatabaseType') eq 'Oracle';
     ok(exists $content->{$_}, "got $_") for @fields;
 
     my $links = $content->{_hyperlinks};
@@ -189,7 +192,9 @@ my $freeform_cf_id;
     is($content->{MaxValues}, 1);
     is($content->{Disabled}, 0);
 
-    my @fields = qw(SortOrder Pattern Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    my @fields = qw(SortOrder Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    # Pattern is undef by default on Oralce and thus excluded from the response
+    push @fields, 'Pattern' unless RT->Config->Get('DatabaseType') eq 'Oracle';
     ok(exists $content->{$_}, "got $_") for @fields;
 
     my $links = $content->{_hyperlinks};
@@ -228,7 +233,9 @@ my $freeform_cf_id;
     is($content->{MaxValues}, 1);
     is($content->{Disabled}, 0);
 
-    my @fields = qw(SortOrder Pattern Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    my @fields = qw(SortOrder Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    # Pattern is undef by default on Oralce and thus excluded from the response
+    push @fields, 'Pattern' unless RT->Config->Get('DatabaseType') eq 'Oracle';
     ok(exists $content->{$_}, "got $_") for @fields;
 
     my $links = $content->{_hyperlinks};
@@ -260,7 +267,9 @@ my $freeform_cf_id;
     is($content->{MaxValues}, 1);
     is($content->{Disabled}, 0);
 
-    my @fields = qw(SortOrder Pattern Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    my @fields = qw(SortOrder Created Creator LastUpdated LastUpdatedBy UniqueValues EntryHint);
+    # Pattern is undef by default on Oralce and thus excluded from the response
+    push @fields, 'Pattern' unless RT->Config->Get('DatabaseType') eq 'Oracle';
     ok(exists $content->{$_}, "got $_") for @fields;
 
     my $links = $content->{_hyperlinks};