Fixing problem with NCC

[itsdarrylnorris]

Problem:

I am having an issue compiling a project using puppeteer-extra-plugin-stealth with NCC.

After some investigation, it looks like the problem it's related to a sub-dependency of the package merge-deep. I created a PR to fix this particular problem in the merge-deep jonschlinkert/merge-deep#14. However, that project does not look like it has been active for the last two years, and I wonder if my PR will even get merge.

Here is the NCC issue explaining the problem: vercel/ncc#500

[jozsi]

This offers better consistency, both packages were being used previously (one occurences of merge-deep and two of deepmerge). Luckily, there is a test for the change you've done.

Please take a look at my question(s) addressed and clean up - if neccessary.

[jozsi]

Is this dependency needed at all for the recaptcha plugin? I don't see any reference to it.

[brunogaspar]

It's being used on line 77 to merge the passed opts with the defaults

[brunogaspar]

As @jozsi pointed out, this is not being used on the recaptcha plugin, therefore the dependency can most likely be removed.

[itsdarrylnorris]

After doing some testing with deepmerge, and puppeteer-extra I found out an issue with deepmerge that it's probably a blocker to use deepmerge, because it does not work with Set and we are using set here

puppeteer-extra/packages/puppeteer-extra-plugin-stealth/index.js

Line 82 in 40c47f1

const availableEvasions = new Set([

I created an issue in deepmerge about this: TehShrike/deepmerge#202

[itsdarrylnorris]

I tried to use object-merge-advanced, but I ran into the same issue as merge-deep.

Any thoughts on how to move forward?

One possible alternative is to use this fork, which I made to merge-deep and it fixes the issue with NCC.

Thoughts?

[berstend]

What's the latest on this, is there a drop in replacement that works with Sets a well?
I'm creating a new base plugin (to support the new Playwright + Puppeteer rewrite) so now would be a good time to change that stuff. 😄

[berstend]

The author responded and mentioned using isPlainObject, I did some quick testing on runkit and think this is fixed?

[itsdarrylnorris]

@berstend I think using deepmerge with isPlainObject it's the way to go. If I am not wrong I ran into other issue with it, but this is unrelated to puppeteer-extra.

Do you want me to make update to this PR to using deepmerge with isPlainObject? Or are you going to include this as part new plugin re-write?

[berstend]

@itsdarrylnorris apologies for the "slight" delay on this 😄 This will be fixed in #303, with this commit.

[itsdarrylnorris]

@berstend No worries, I stopped using NCC it causes too many issues. Thanks for the #303 hard work.