-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed GitLab workspace integration #1523
base: master
Are you sure you want to change the base?
Conversation
Changed getTree to a recursive function so it iterates through all pages of the GitLab API's response when fetching the tree.
I applied this patch and can confirm that this fixes #1629 . Is there any chance of this landing and being added to a release? |
Maybe not though, me and other people are still experiencing file mysteriously disappearing. |
I've just found out something. I have 89 pages at this moment and now I understand why I started to notice the issue. Well, in my case it seems there's a files visibility limit (and it's 80), does it makes sense? |
Yes, as is stackedit tries to create a list of 9999 items (IIRC), but gitlab well silently cap that. With this patch (which is not in master), it parses additional pages, thus fixing the issue. I've pretty much given up on stackedit though, it seems abandoned, and it needs do much work to update dependencies with gaping security holes |
@dcbaker Yeah, but it's a pity... |
@lorenx, sorry, I do development on github and get a lot of messages. I've been using dillinger.io, but github intergration is broken there too now, so I've just been using the gitlab online editor. It's not great, but at least it keeps working... |
Changed getTree to a recursive function so it iterates through all pages of the GitLab API's response when fetching the tree. Fixes #1462 and #1505 for real this time.