Build 12 [1.0b12] #540
Merged
Build 12 [1.0b12] #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This really got out of hand. When I started, I just wanted to maybe start
working on getting player.connect() working:
Started as a refactor, but I discovered that Entity controls were not functioning properly.
(and discovered that the mineraft entity controls actually are not as robust as ours).
- Refactored all packet constants to a standard format:
CONSTANT = [PACKET, [PARSING]], where PACKET = 0xNN packet number and parsing
is a list of constants like [VARINT, BOOL, STRING]. Some packets already
followed this convention, but most simply defined packets like `PACKET_NAME = 0xNN`
- Correct errors with new mcserver.py `_console_event` function not sending commands anywhere
except for the wrapper interface.
- Corrected Entities config items listing old names (i.e. - 'Sheep' was changed to 'sheep' in 11.1)
- Added internal wrapper event 'server.autoCompletes' to process (future) autocompletions.
- Added optimization to make non-abortable events spur off in their own thread to prevent
delays to wrapper (and in proxy mode, proxy packet) processing.
- Removed "player.runCommand" event from public API. It is now private event. Also
changed the behaviour to not be "abortable".. I.e. any command _will_ abort and get
processed directly by _either_ wrapper or the server.
- All registered commands run on their own thread, so wrapper plugin commands
do not pause proxy!
- All non-abortable events run as a deamon thread, allowing wrapper to continue
running while any event runs on a separate thread.
- Made improvements to whitelist commands `online` and `offline`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, I did too much in this build!
Started as a refactor, but I discovered that Entity controls were not functioning properly.
(and discovered that the mineraft entity controls actually are not as robust as ours).
CONSTANT = [PACKET, [PARSING]], where PACKET = 0xNN packet number and parsing
is a list of constants like [VARINT, BOOL, STRING]. Some packets already
followed this convention, but most simply defined packets like
PACKET_NAME = 0xNN_console_eventfunction not sending commands anywhereexcept for the wrapper interface.
delays to wrapper (and in proxy mode, proxy packet) processing.
changed the behaviour to not be "abortable".. I.e. any command will abort (i.e. the packet the client sent) and get processed directly by either wrapper or the server.
do not pause proxy!
running while any event runs on a separate thread.
onlineandoffline.