Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various warnings #891

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix various warnings #891

merged 1 commit into from
Jul 30, 2024

Conversation

jaredsburrows
Copy link
Collaborator

Fix various warnings such as:

w: file:///Users/<>/repo/gradle-versions-plugin/gradle-versions-plugin/src/main/kotlin/com/github/benmanes/gradle/versions/updates/DependencyUpdatesTask.kt:127:66 Java type mismatch: inferred type is 'groovy.lang.Closure<*>', but 'groovy.lang.Closure<kotlin.Any!>' was expected.

@jaredsburrows jaredsburrows requested a review from ben-manes July 30, 2024 05:15
ben-manes
ben-manes reviewed Jul 30, 2024
View reviewed changes
...ions-plugin/src/main/kotlin/com/github/benmanes/gradle/versions/updates/DependencyUpdates.kt Outdated
val project: Project,
val resolutionStrategy: Action<in ResolutionStrategyWithCurrent>?,
val revision: String,
private val project: Project,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m doubtful, but an extension plugin could have used this constructor if public. It might not be worth worrying about though

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/fkorotkov/gradle-libraries-plugin/blob/92311acf0cdd7019f7ba7fb55d7c70e98acde9ec/src/main/java/com/fkorotkov/gradle/libraries/tasks/LibrariesBaseTask.java#L47

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

@jaredsburrows jaredsburrows force-pushed the pr/jaredsburrows/fix-various-warnings branch from 106dd3b to 70af87a Compare July 30, 2024 05:33
@jaredsburrows jaredsburrows force-pushed the pr/jaredsburrows/fix-various-warnings branch from 70af87a to a33067a Compare July 30, 2024 05:53
@jaredsburrows jaredsburrows merged commit a30c209 into master Jul 30, 2024
2 checks passed
@jaredsburrows jaredsburrows deleted the pr/jaredsburrows/fix-various-warnings branch July 30, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-manes ben-manes ben-manes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredsburrows @ben-manes