-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 17 #644
base: master
Are you sure you want to change the base?
Java 17 #644
Conversation
I think this is to be expected since Gradle does not support jdk18 yet |
The documentation does seem to be updated - https://docs.gradle.org/current/userguide/compatibility.html. |
yeah, other jdks may work or may not until officially supported. That is a bit annoying since it means one cannot test against EA builds and Gradle lags in their release cycle. They used to have 6 weeks releases between minor but lately it seems they are behind (7.4 was early Feb). |
2487284
to
ef5de88
Compare
I'd suggest adding JDK 17 instead of 18 as it is the latest LTS version. |
You should be able to merge this now, Gradle supports Java 19 as of 7.6. The 6 week release cycle is something we're trying hard to get back to. It looks like 8.2 is going to follow very close on the heels of 8.1. |
@jaredsburrows can you rebase and merge if all looks good? |
@ben-manes Odd, there should be a "Update Branch" button. Can you go to the repo's settings? https://github.com/jaredsburrows/cs-interview-questions/settings and look for the following "Always suggest updating pull request branches ": This way folks can update via github.com and then I can click on "Rebase and merge" before submitting. |
done, good catch! |
53d61d7
to
20d8d2a
Compare
Supporting Java LTS versions: 8, 11, 17
https://www.oracle.com/java/technologies/java-se-support-roadmap.html