Skip to content

Commit

Permalink
Fix SCM connection URLs when publishing
Browse files Browse the repository at this point in the history
Both URLs were missing the [provider] part (here "git"), see https://maven.apache.org/pom.html#SCM.
Also, the connection URL must be usable for anonymous clones, so it should not contain a user name.
Finally, GitHub does not endorse the use of the "git" protocol, so use "ssh" for the authenticated developer
connection instead.
  • Loading branch information
sschuberth authored Feb 9, 2020
1 parent 608d5b4 commit 8c397e2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gradle/publish.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ publishing {

scm {
url = 'https://github.com/ben-manes/caffeine'
connection = 'scm:https://ben-manes@github.com/ben-manes/caffeine.git'
developerConnection = 'scm:git://github.com/ben-manes/caffeine.git'
connection = 'scm:git:https://github.com/ben-manes/caffeine.git'
developerConnection = 'scm:git:ssh://git@github.com/ben-manes/caffeine.git'
}

licenses {
Expand Down

0 comments on commit 8c397e2

Please sign in to comment.