fix sonarlint warnings for tests, remove duplicative, add missing #1245

	name: Scorecards
	on:
	branch_protection_rule:
	schedule:
	- cron: '45 17 * * 2'
	push:
	branches: [ master ]

	permissions: read-all

	jobs:
	analysis:
	name: Scorecards analysis
	runs-on: ubuntu-latest
	permissions:
	security-events: write
	id-token: write
	actions: read
	contents: read
	if: github.event.repository.fork == false
	steps:
	- name: Harden Runner
	uses: step-security/harden-runner@17d0e2bd7d51742c71671bd19fa12bdc9d40a3d6 # v2.8.1
	with:
	disable-sudo: true
	egress-policy: block
	allowed-endpoints: >
	api.github.com:443
	api.osv.dev:443
	api.securityscorecards.dev:443
	api.scorecard.dev:443
	auth.docker.io:443
	bestpractices.coreinfrastructure.org:443
	fulcio.sigstore.dev:443
	github.com:443
	index.docker.io:443
	oss-fuzz-build-logs.storage.googleapis.com:443
	rekor.sigstore.dev:443
	sigstore-tuf-root.storage.googleapis.com:443
	tuf-repo-cdn.sigstore.dev:443
	www.bestpractices.dev:443
	- name: Checkout code
	uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
	with:
	persist-credentials: false
	- name: Run analysis
	uses: ossf/scorecard-action@dc50aa9510b46c811795eb24b2f1ba02a914e534 # v2.3.3
	with:
	publish_results: true
	results_format: sarif
	results_file: results.sarif
	repo_token: ${{ secrets.SCORECARD_READ_TOKEN }}
	- name: Upload artifact
	uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
	with:
	name: SARIF file
	path: results.sarif
	retention-days: 5
	- name: Upload to code-scanning
	uses: github/codeql-action/upload-sarif@2e230e8fe0ad3a14a340ad0815ddb96d599d2aff # v3.25.8
	with:
	sarif_file: results.sarif

Provide feedback