Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of unit tests.
Two are failing.
_lt
is a reserved keyword, but it is also being used as a way to detect classes which are tasks - and we don't raise errors about reserved attributes in such cases. Is this just for if we are inheriting from a previously defined Task class? I wonder whether there is a better way to do this (perhaps by inspecting directly the MRO), because I think we still want to protect the user if they accidentally use_lt
as an attribute.Keen to know what you'd do about this.