-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable all examples #56
Conversation
aeb4ea7
to
f2aca35
Compare
f2aca35
to
f0b692f
Compare
8ad1ed0
to
8896a10
Compare
0d64c0c
to
454c1de
Compare
cmake/CompilerFeatureTest.cmake
Outdated
|
||
check_cxx_source_compiles( | ||
" | ||
#include <ranges> // C++20 ranges; note that __cpp_lib_ranges is not defined for all compilers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What compiler doesn't define it?
BTW, when searching for __cpp_lib_ranges
using GitHub code search I found this alternative way to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have adopted this in my latest contribution.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Any interest in progressing this? I can come update it. @neatudarius |
You can take over. I'm busy with iterator_interface this week. |
Should be working now, see: Unit: gcc 17 Default, that reports |
Updated default C++ version in preset to C++ 20 (previously C++17) so that all examples are built by default. |
Should be ready! requesting review from original PR author @neatudarius |
Closes #41 - re-enable example with ranges support. It is skipped on compilers with no ranges support or when using C++17 or older.
Log sample: