[DO NOT MERGE] Test reviewdog #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
Merged
|
Permission issue persists. Please forward discussion to #49 as this involves GitHub project setting. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+4
to
+5
| * @bretbrownjr @camio @dietmarkuehl @neatudarius @steve-downey | ||
|
|
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| * @bretbrownjr @camio @dietmarkuehl @neatudarius @steve-downey | |
| * @bretbrownjr @camio @dietmarkuehl @neatudarius @steve-downey |
Comment on lines
+38
to
+41
| int | ||
| size | ||
| = | ||
| 0; |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| int | |
| size | |
| = | |
| 0; | |
| int size = 0; |
|
@neatudarius review dog is working now!!! YEY!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46 introduced reviewdog but was having problem (#48).
#49 attempted to fix those problems. But not sure if that fixes it due to permission complications.
Unfortunately there's not a good way to test GitHub Actions and reviewdog, so I have to create this pr to see if they are working correctly.
Sorry for spamming the notification.
Expected: