forked from PMBio/peer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update peer to compile and work on modern platforms. #1
Open
pettyalex
wants to merge
43
commits into
master
Choose a base branch
from
update-peer-2024
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Python using vendored Eigen.
…ary and no longer necessary numpy include script.
…th python and R locally
… python package builds with C++14.
Thanks for this work. I had just started the the original and subsequent bioFAM fork, with the objective of getting things building in a container. I also started checking whether we can use https://github.com/bioFAM/MOFA2, which seems to have originated as a re-implementation of peer. In any case, if you are interested in PR's I'll be happy to put things up against this branch as I find / fix things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got this building locally with an external Eigen in Conda, I'm going to figure out a better way to do that but this works for now.
This is mostly updating CMakeLists, and I got it compiling on my apple silicon mac!