Skip to content

Commit

Permalink
Implement EVP_MAC_init_SKEY
Browse files Browse the repository at this point in the history
  • Loading branch information
beldmit committed Nov 15, 2024
1 parent 8a1a2e7 commit 50b743d
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 4 deletions.
15 changes: 15 additions & 0 deletions crypto/evp/mac_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,21 @@ int EVP_MAC_init(EVP_MAC_CTX *ctx, const unsigned char *key, size_t keylen,
return ctx->meth->init(ctx->algctx, key, keylen, params);
}

int EVP_MAC_init_SKEY(EVP_MAC_CTX *ctx, const EVP_SKEY *skey, const OSSL_PARAM params[])
{
if (ctx->meth->init_opaque == NULL) {
ERR_raise(ERR_R_EVP_LIB, ERR_R_UNSUPPORTED);
return 0;
}

if (skey->keymgmt->prov != ctx->meth->prov) {
ERR_raise(ERR_R_EVP_LIB, ERR_R_UNSUPPORTED);
return 0;
}

return ctx->meth->init_opaque(ctx->algctx, skey->keydata, params);
}

int EVP_MAC_update(EVP_MAC_CTX *ctx, const unsigned char *data, size_t datalen)
{
return ctx->meth->update(ctx->algctx, data, datalen);
Expand Down
8 changes: 7 additions & 1 deletion crypto/evp/mac_meth.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,15 @@ static void *evp_mac_from_algorithm(int name_id,
break;
mac->set_ctx_params = OSSL_FUNC_mac_set_ctx_params(fns);
break;
case OSSL_FUNC_MAC_INIT_OPAQUE:
if (mac->init_opaque != NULL)
break;
mac->init_opaque = OSSL_FUNC_mac_init_opaque(fns);
fnmaccnt++;
break;
}
}
if (fnmaccnt != 3
if ((fnmaccnt != 3 && fnmaccnt != 4)
|| fnctxcnt != 2) {
/*
* In order to be a consistent set of functions we must have at least
Expand Down
12 changes: 9 additions & 3 deletions doc/man3/EVP_MAC.pod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ EVP_MAC_get0_provider, EVP_MAC_get_params, EVP_MAC_gettable_params,
EVP_MAC_CTX, EVP_MAC_CTX_new, EVP_MAC_CTX_free, EVP_MAC_CTX_dup,
EVP_MAC_CTX_get0_mac, EVP_MAC_CTX_get_params, EVP_MAC_CTX_set_params,
EVP_MAC_CTX_get_mac_size, EVP_MAC_CTX_get_block_size, EVP_Q_mac,
EVP_MAC_init, EVP_MAC_update, EVP_MAC_final, EVP_MAC_finalXOF,
EVP_MAC_init, EVP_MAC_init_SKEY, EVP_MAC_update, EVP_MAC_final, EVP_MAC_finalXOF,
EVP_MAC_gettable_ctx_params, EVP_MAC_settable_ctx_params,
EVP_MAC_CTX_gettable_params, EVP_MAC_CTX_settable_params,
EVP_MAC_do_all_provided - EVP MAC routines
Expand Down Expand Up @@ -49,6 +49,7 @@ EVP_MAC_do_all_provided - EVP MAC routines
unsigned char *out, size_t outsize, size_t *outlen);
int EVP_MAC_init(EVP_MAC_CTX *ctx, const unsigned char *key, size_t keylen,
const OSSL_PARAM params[]);
int EVP_MAC_init_SKEY(EVP_MAC_CTX *ctx, const EVP_SKEY *skey, const OSSL_PARAM params[]);
int EVP_MAC_update(EVP_MAC_CTX *ctx, const unsigned char *data, size_t datalen);
int EVP_MAC_final(EVP_MAC_CTX *ctx,
unsigned char *out, size_t *outl, size_t outsize);
Expand Down Expand Up @@ -151,6 +152,9 @@ has been called on the same object). See the NOTES section below.

EVP_MAC_init() should be called before EVP_MAC_update() and EVP_MAC_final().

EVP_MAC_init_SKEY() is similar to EVP_MAC_init() but accepts an opaque
B<EVP_SKEY> object as a key.

EVP_MAC_update() adds I<datalen> bytes from I<data> to the MAC input.

EVP_MAC_final() does the final computation and stores the result in
Expand Down Expand Up @@ -384,8 +388,8 @@ success, 0 on error.

EVP_Q_mac() returns a pointer to the computed MAC value, or NULL on error.

EVP_MAC_init(), EVP_MAC_update(), EVP_MAC_final(), and EVP_MAC_finalXOF()
return 1 on success, 0 on error.
EVP_MAC_init(), EVP_MAC_init_SKEY(), EVP_MAC_update(), EVP_MAC_final(), and
EVP_MAC_finalXOF() return 1 on success, 0 on error.

EVP_MAC_CTX_get_mac_size() returns the expected output size, or 0 if it isn't
set. If it isn't set, a call to EVP_MAC_init() will set it.
Expand Down Expand Up @@ -491,6 +495,8 @@ L<life_cycle-mac(7)>

These functions were added in OpenSSL 3.0.

The EVP_MAC_init_SKEY() function was added in OpenSSL 3.5.

=head1 COPYRIGHT

Copyright 2018-2024 The OpenSSL Project Authors. All Rights Reserved.
Expand Down
1 change: 1 addition & 0 deletions include/crypto/evp.h
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ struct evp_mac_st {
OSSL_FUNC_mac_get_params_fn *get_params;
OSSL_FUNC_mac_get_ctx_params_fn *get_ctx_params;
OSSL_FUNC_mac_set_ctx_params_fn *set_ctx_params;
OSSL_FUNC_mac_init_opaque_fn *init_opaque;
};

struct evp_kdf_st {
Expand Down
2 changes: 2 additions & 0 deletions include/openssl/core_dispatch.h
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ OSSL_CORE_MAKE_FUNC(void, cipher_freeskey, (void *ptr))
# define OSSL_FUNC_MAC_GETTABLE_PARAMS 10
# define OSSL_FUNC_MAC_GETTABLE_CTX_PARAMS 11
# define OSSL_FUNC_MAC_SETTABLE_CTX_PARAMS 12
# define OSSL_FUNC_MAC_INIT_OPAQUE 13

OSSL_CORE_MAKE_FUNC(void *, mac_newctx, (void *provctx))
OSSL_CORE_MAKE_FUNC(void *, mac_dupctx, (void *src))
Expand All @@ -438,6 +439,7 @@ OSSL_CORE_MAKE_FUNC(int, mac_get_ctx_params,
(void *mctx, OSSL_PARAM params[]))
OSSL_CORE_MAKE_FUNC(int, mac_set_ctx_params,
(void *mctx, const OSSL_PARAM params[]))
OSSL_CORE_MAKE_FUNC(int, mac_init_opaque, (void *mctx, const void *key, const OSSL_PARAM params[]))

/* KDFs and PRFs */

Expand Down
1 change: 1 addition & 0 deletions include/openssl/evp.h
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,7 @@ unsigned char *EVP_Q_mac(OSSL_LIB_CTX *libctx, const char *name, const char *pro
unsigned char *out, size_t outsize, size_t *outlen);
int EVP_MAC_init(EVP_MAC_CTX *ctx, const unsigned char *key, size_t keylen,
const OSSL_PARAM params[]);
int EVP_MAC_init_SKEY(EVP_MAC_CTX *ctx, const EVP_SKEY *skey, const OSSL_PARAM params[]);
int EVP_MAC_update(EVP_MAC_CTX *ctx, const unsigned char *data, size_t datalen);
int EVP_MAC_final(EVP_MAC_CTX *ctx,
unsigned char *out, size_t *outl, size_t outsize);
Expand Down
1 change: 1 addition & 0 deletions util/libcrypto.num
Original file line number Diff line number Diff line change
Expand Up @@ -5759,3 +5759,4 @@ EVP_SKEY_free ? 3_5_0 EXIST::FUNCTION:
EVP_SKEY_dup ? 3_5_0 EXIST::FUNCTION:
EVP_KDF_derive_SKEY ? 3_5_0 EXIST::FUNCTION:
EVP_PKEY_derive_SKEY ? 3_5_0 EXIST::FUNCTION:
EVP_MAC_init_SKEY ? 3_5_0 EXIST::FUNCTION:

0 comments on commit 50b743d

Please sign in to comment.