Fix progress bar colors when using dynamic #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
requested changes
Sep 18, 2024
|
Good find, we can probably fix this by assigning a separate color attribute just for the progress bars. Will do that soon™️ |
michaelschattgen
force-pushed
the
fix/dynamic-progress-color
branch
2 times, most recently
from
c0e43c6
to
6108ea3
Compare
alexbakker
force-pushed
the
fix/dynamic-progress-color
branch
from
6108ea3
to
eb7b888
Compare
alexbakker
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the visibility of the progressbar when using 'dynamic colors' in combination with dark and amoled themes. With this PR the progressbar will have the same color as the profile codes and thus will never be too dark.
Fixes #1350