Add tiles view mode #1096
Merged
Add tiles view mode #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
requested changes
Mar 1, 2023
There was a problem hiding this comment.
Looks nice! Other than a couple of nitpicks the changes look good to me.
I noticed a couple of interesting bugs though:
- It makes sense that 8-digit HOTP entries take some extra space. If I move a regularly sized card to a spot with a larger one next to it, the smaller one grows to be the same size as the large one. That makes sense. If I move it back to its original spot however, it stays the same size. Once a refresh happens, it snaps back to its original size. Demo: https://alexbakker.me/u/1upmhthhz7.mp4.
- If I move an entry one spot down and then select the entry that took its place, something odd happens that's kind of hard to describe: https://alexbakker.me/u/w73e6v6nk8.mp4.
app/src/main/java/com/beemdevelopment/aegis/helpers/SimpleItemTouchHelperCallback.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/view-mode-tiles
branch
from
2c650ee
to
1d4c445
Compare
|
Both issues are fixed and PR can be reviewed again. |
michaelschattgen
force-pushed
the
feature/view-mode-tiles
branch
5 times, most recently
from
047a530
to
e1f5e57
Compare
|
Resolved merge conflicts from master (again) and removed the superfluous 'swap' function. |
michaelschattgen
force-pushed
the
feature/view-mode-tiles
branch
from
e1f5e57
to
298b80f
Compare
Minor UI improvements Fix animations Fix typo Improvements made after PR review PR improvements Co-authored-by: Alexander Bakkker <[email protected]>
michaelschattgen
force-pushed
the
feature/view-mode-tiles
branch
from
298b80f
to
d90303c
Compare
alexbakker
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tile view as previously discussed in multiple issues but mainly #547.
Closes #547