Code optimizations (using client shortcuts).

bearcms · May 8, 2019 · dcdc4e1 · dcdc4e1
1 parent 5967f0a
commit dcdc4e1
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/autoload.php b/autoload.php
@@ -10,6 +10,7 @@
 BearFramework\Addons::register('bearcms/embed-element-addon', __DIR__, [
     'require' => [
         'bearcms/bearframework-addon',
-        'bearframework/localization-addon'
+        'bearframework/localization-addon',
+        'ivopetkov/client-shortcuts-bearframework-addon'
     ]
 ]);
diff --git a/components/embedElement.php b/components/embedElement.php
@@ -135,8 +135,7 @@
 }
 ?><html>
     <head>
-        <style id="responsively-lazy-style">.responsively-lazy:not(img){position:relative;height:0;}.responsively-lazy:not(img)>img{position:absolute;top:0;left:0;width:100%;height:100%}img.responsively-lazy{width:100%;}</style>
-        <script id="responsively-lazy-script" src="<?= $context->assets->getURL('assets/responsivelyLazy.min.js', ['cacheMaxAge' => 999999999, 'version' => 2]) ?>" async/>
+        <link rel="client-shortcuts-embed" name="-bearcms-embed-element-responsively-lazy">
     </head>
     <body><?= $content ?></body>
 </html>
diff --git a/composer.json b/composer.json
@@ -15,7 +15,8 @@
         "php": ">=7.1",
         "bearcms/bearframework-addon": "1.*",
         "bearframework/localization-addon": "0.2.*",
-        "ivopetkov/html5-dom-document-php": "2.*"
+        "ivopetkov/html5-dom-document-php": "2.*",
+        "ivopetkov/client-shortcuts-bearframework-addon": "0.1.*"
     },
     "autoload": {
         "files": ["autoload.php"]

diff --git a/index.php b/index.php
@@ -55,5 +55,20 @@
                         ]
                     ]);
                 };
+
+                $app->clientShortcuts
+                ->add('-bearcms-embed-element-responsively-lazy', function(IvoPetkov\BearFrameworkAddons\ClientShortcut $shortcut) use ($context) {
+                    $shortcut->requirements[] = [
+                        'type' => 'file',
+                        'url' => $context->assets->getURL('assets/responsivelyLazy.min.js', ['cacheMaxAge' => 999999999, 'version' => 2]),
+                        'async' => true,
+                        'mimeType' => 'text/javascript'
+                    ];
+                    $shortcut->requirements[] = [
+                        'type' => 'text',
+                        'value' => '.responsively-lazy:not(img){position:relative;height:0;}.responsively-lazy:not(img)>img{position:absolute;top:0;left:0;width:100%;height:100%}img.responsively-lazy{width:100%;}',
+                        'mimeType' => 'text/css'
+                    ];
+                });
             };
         });