Cart in socket #32

MICHAELMUNAVU83 · 2023-10-18T02:09:23Z

Notes for the reviewer

I have worked on adding items in the cart using the socket to avoid interacting with the db

GIF (for features)

Screen.Recording.2023-10-18.at.05.07.45.mov

Bumps [phoenix_live_dashboard](https://github.com/phoenixframework/phoenix_live_dashboard) from 0.8.1 to 0.8.2. - [Release notes](https://github.com/phoenixframework/phoenix_live_dashboard/releases) - [Changelog](https://github.com/phoenixframework/phoenix_live_dashboard/blob/main/CHANGELOG.md) - [Commits](phoenixframework/phoenix_live_dashboard@v0.8.1...v0.8.2) --- updated-dependencies: - dependency-name: phoenix_live_dashboard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [swoosh](https://github.com/swoosh/swoosh) from 1.11.6 to 1.12.0. - [Release notes](https://github.com/swoosh/swoosh/releases) - [Changelog](https://github.com/swoosh/swoosh/blob/main/CHANGELOG.md) - [Commits](swoosh/swoosh@v1.11.6...v1.12.0) --- updated-dependencies: - dependency-name: swoosh dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [credo](https://github.com/rrrene/credo) from 1.7.0 to 1.7.1. - [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md) - [Commits](https://github.com/rrrene/credo/commits) --- updated-dependencies: - dependency-name: credo dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bump swoosh from 1.11.6 to 1.12.0

Bump credo from 1.7.0 to 1.7.1

…hboard-0.8.2 Bump phoenix_live_dashboard from 0.8.1 to 0.8.2

Bumps [phoenix_html](https://github.com/phoenixframework/phoenix_html) from 3.3.2 to 3.3.3. - [Changelog](https://github.com/phoenixframework/phoenix_html/blob/main/CHANGELOG.md) - [Commits](phoenixframework/phoenix_html@v3.3.2...v3.3.3) --- updated-dependencies: - dependency-name: phoenix_html dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.17.1 to 0.18.0. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.17.1...v0.18.0) --- updated-dependencies: - dependency-name: excoveralls dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [phoenix_live_view](https://github.com/phoenixframework/phoenix_live_view) from 0.19.5 to 0.20.1. - [Changelog](https://github.com/phoenixframework/phoenix_live_view/blob/main/CHANGELOG.md) - [Commits](phoenixframework/phoenix_live_view@v0.19.5...v0.20.1) --- updated-dependencies: - dependency-name: phoenix_live_view dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [phoenix](https://github.com/phoenixframework/phoenix) from 1.7.7 to 1.7.9. - [Release notes](https://github.com/phoenixframework/phoenix/releases) - [Changelog](https://github.com/phoenixframework/phoenix/blob/main/CHANGELOG.md) - [Commits](phoenixframework/phoenix@v1.7.7...v1.7.9) --- updated-dependencies: - dependency-name: phoenix dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [floki](https://github.com/philss/floki) from 0.34.3 to 0.35.0. - [Release notes](https://github.com/philss/floki/releases) - [Changelog](https://github.com/philss/floki/blob/main/CHANGELOG.md) - [Commits](philss/floki@v0.34.3...v0.35.0) --- updated-dependencies: - dependency-name: floki dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

75pollet · 2023-10-18T17:46:14Z

lib/elixir_conf_africa_web/live/home_live/index.ex

+  def handle_event("add_to_cart", %{"id" => id}, socket) do
+    ticket_type =
+      id
+      |> String.to_integer()


you do not need to convert the id to an integer here. Repo.get will still succeed

75pollet · 2023-10-18T17:50:02Z

lib/elixir_conf_africa_web/live/home_live/index.ex

+    if Enum.member?(socket.assigns.cart, ticket_type) do
+      {:noreply,
+       socket
+       |> put_flash(:error, "Ticket already in cart")}


is this what should happen if the ticket is already added to cart? 🤔 In this scenario shouldn't we increment the quantity of the ticket?

75pollet · 2023-10-18T17:52:40Z

lib/elixir_conf_africa_web/live/home_live/index.html.heex

-    <p>
+    <p
+      phx-value-page_state="cart"
+      phx-click="change_page_state"


what is this event meant to do? I suggest you name it differently because its a bit confusing

Bump floki from 0.34.3 to 0.35.0

Bump phoenix from 1.7.7 to 1.7.9

…w-0.20.1 Bump phoenix_live_view from 0.19.5 to 0.20.1

Bump excoveralls from 0.17.1 to 0.18.0

Bump phoenix_html from 3.3.2 to 3.3.3

okothkongo

Let's make the main branch our branch out for other branches.
I see this one branching out from style-home-with-event-and-ticket-details

Bumps [dialyxir](https://github.com/jeremyjh/dialyxir) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/jeremyjh/dialyxir/releases) - [Changelog](https://github.com/jeremyjh/dialyxir/blob/master/CHANGELOG.md) - [Commits](jeremyjh/dialyxir@1.4.1...1.4.2) --- updated-dependencies: - dependency-name: dialyxir dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [floki](https://github.com/philss/floki) from 0.35.0 to 0.35.1. - [Release notes](https://github.com/philss/floki/releases) - [Changelog](https://github.com/philss/floki/blob/main/CHANGELOG.md) - [Commits](philss/floki@v0.35.0...v0.35.1) --- updated-dependencies: - dependency-name: floki dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

MICHAELMUNAVU83 · 2023-10-23T14:02:18Z

Let's make the main branch our branch out for other branches. I see this one branching out from style-home-with-event-and-ticket-details

Hey @okothkongo , I did this as I needed the material from style-home-with-event-and-ticket-details as you hadn't merged it yet

okothkongo · 2023-10-23T14:11:08Z

Let's make the main branch our branch out for other branches. I see this one branching out from style-home-with-event-and-ticket-details

Hey @okothkongo , I did this as I needed the material from style-home-with-event-and-ticket-details as you hadn't merged it yet

It is my suggestion that we refrain from progressing with work until it has undergone a thorough review and been merged into the main branch. This approach ensures that our codebase consistently meets our quality standards before it becomes a part of the main codebase.

To facilitate this, we could designate a specific task, such as 'style-home-with-event-and-ticket-details,' as a blocker for other work. This way, we have a clear and standardized process for handling code changes.

Maintaining a single source of truth, which in our case is the 'main' branch, is essential to prevent confusion and maintain order within our project. I believe that by adopting this approach, we can enhance collaboration and streamline our development process.

…t-details Style home with event and ticket details

Bump floki from 0.35.0 to 0.35.1

Bump dialyxir from 1.4.1 to 1.4.2

Bumps [floki](https://github.com/philss/floki) from 0.35.1 to 0.35.2. - [Release notes](https://github.com/philss/floki/releases) - [Changelog](https://github.com/philss/floki/blob/main/CHANGELOG.md) - [Commits](philss/floki@v0.35.1...v0.35.2) --- updated-dependencies: - dependency-name: floki dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [phoenix_live_dashboard](https://github.com/phoenixframework/phoenix_live_dashboard) from 0.8.2 to 0.8.3. - [Release notes](https://github.com/phoenixframework/phoenix_live_dashboard/releases) - [Changelog](https://github.com/phoenixframework/phoenix_live_dashboard/blob/main/CHANGELOG.md) - [Commits](phoenixframework/phoenix_live_dashboard@v0.8.2...v0.8.3) --- updated-dependencies: - dependency-name: phoenix_live_dashboard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bump floki from 0.35.1 to 0.35.2

…hboard-0.8.3 Bump phoenix_live_dashboard from 0.8.2 to 0.8.3

…onfAfrica into cart-in-socket

dependabot bot and others added 14 commits September 25, 2023 12:01

Merge pull request #22 from beamkenya/dependabot/hex/swoosh-1.12.0

5d9c057

Bump swoosh from 1.11.6 to 1.12.0

Merge pull request #21 from beamkenya/dependabot/hex/credo-1.7.1

bc923ca

Bump credo from 1.7.0 to 1.7.1

Merge pull request #20 from beamkenya/dependabot/hex/phoenix_live_das…

4c40181

…hboard-0.8.2 Bump phoenix_live_dashboard from 0.8.1 to 0.8.2

Started add to cart with sockets

09814ac

Added cart in socket

f5db2d4

Refractored pipe function

0145e70

MICHAELMUNAVU83 marked this pull request as draft October 18, 2023 02:13

75pollet requested changes Oct 18, 2023

View reviewed changes

75pollet marked this pull request as ready for review October 18, 2023 17:53

okothkongo added 5 commits October 21, 2023 09:17

Merge pull request #31 from beamkenya/dependabot/hex/floki-0.35.0

70e1902

Bump floki from 0.34.3 to 0.35.0

Merge pull request #30 from beamkenya/dependabot/hex/phoenix-1.7.9

04a4ac5

Bump phoenix from 1.7.7 to 1.7.9

Merge pull request #29 from beamkenya/dependabot/hex/phoenix_live_vie…

647c828

…w-0.20.1 Bump phoenix_live_view from 0.19.5 to 0.20.1

Merge pull request #28 from beamkenya/dependabot/hex/excoveralls-0.18.0

5892518

Bump excoveralls from 0.17.1 to 0.18.0

Merge pull request #27 from beamkenya/dependabot/hex/phoenix_html-3.3.3

88738ba

Bump phoenix_html from 3.3.2 to 3.3.3

okothkongo requested changes Oct 23, 2023

View reviewed changes

dependabot bot added 2 commits October 23, 2023 11:58

okothkongo added 3 commits October 24, 2023 20:26

Merge pull request #26 from beamkenya/style-home-with-event-and-ticke…

137f658

…t-details Style home with event and ticket details

Merge pull request #34 from beamkenya/dependabot/hex/floki-0.35.1

8c11c33

Bump floki from 0.35.0 to 0.35.1

Merge pull request #33 from beamkenya/dependabot/hex/dialyxir-1.4.2

cf0bef8

Bump dialyxir from 1.4.1 to 1.4.2

dependabot bot and others added 8 commits October 30, 2023 11:49

Merge pull request #36 from beamkenya/dependabot/hex/floki-0.35.2

bcfafca

Bump floki from 0.35.1 to 0.35.2

Merge pull request #37 from beamkenya/dependabot/hex/phoenix_live_das…

de920e8

…hboard-0.8.3 Bump phoenix_live_dashboard from 0.8.2 to 0.8.3

Started add to cart with sockets

4c9027d

Added cart in socket

9ad48f1

Refractored pipe function

04d166b

Merge branch 'cart-in-socket' of https://github.com/beamkenya/ElixirC…

5ce7e45

…onfAfrica into cart-in-socket

MICHAELMUNAVU83 closed this Nov 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cart in socket #32

Cart in socket #32

MICHAELMUNAVU83 commented Oct 18, 2023

75pollet Oct 18, 2023

75pollet Oct 18, 2023

75pollet Oct 18, 2023

okothkongo left a comment •

edited

Loading

MICHAELMUNAVU83 commented Oct 23, 2023

okothkongo commented Oct 23, 2023

Cart in socket #32

Cart in socket #32

Conversation

MICHAELMUNAVU83 commented Oct 18, 2023

Notes for the reviewer

GIF (for features)

75pollet Oct 18, 2023

Choose a reason for hiding this comment

75pollet Oct 18, 2023

Choose a reason for hiding this comment

75pollet Oct 18, 2023

Choose a reason for hiding this comment

okothkongo left a comment • edited Loading

Choose a reason for hiding this comment

MICHAELMUNAVU83 commented Oct 23, 2023

okothkongo commented Oct 23, 2023

okothkongo left a comment •

edited

Loading