-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style home with event and ticket details #26
Conversation
I also strongly feel the PR should be split into two or more PRs. One to deal with the introduction of styling and introduction of CSS |
Yeah , we should have , we can divide the further upcoming tasks into smaller and smaller tasks |
I noticed some of the PRs are very large. I suggest having a reasonable amount of work in these PRs which makes it easier for reviewers to review and make suggestions. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a literal value; there is no need for the pin.
Could we also join on name
and get rid of the where
clause?
By the way, why "ElixirConf Africa 2024" can make it dynamic allowing Front End to supply us with the name?
A quick one @MICHAELMUNAVU83 could also write tests that will be beneficial in the future. If have a lot in your plate at the moment I can push some against on your branch |
-In this PR , I styled the home page that contains the events and the various ticket types
Navigate to /home to see the work , you can add events at /events and ticket types at /ticket_types