Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style home with event and ticket details #26

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

MICHAELMUNAVU83
Copy link
Collaborator

-In this PR , I styled the home page that contains the events and the various ticket types
Navigate to /home to see the work , you can add events at /events and ticket types at /ticket_types

Screenshot 2023-10-12 at 09 20 07

@MICHAELMUNAVU83 MICHAELMUNAVU83 self-assigned this Oct 12, 2023
@MICHAELMUNAVU83 MICHAELMUNAVU83 linked an issue Oct 12, 2023 that may be closed by this pull request
okothkongo

This comment was marked as off-topic.

config/dev.exs Outdated Show resolved Hide resolved
lib/elixir_conf_africa/events.ex Outdated Show resolved Hide resolved
lib/elixir_conf_africa/events.ex Outdated Show resolved Hide resolved
@okothkongo
Copy link
Collaborator

I also strongly feel the PR should be split into two or more PRs.

One to deal with the introduction of styling and introduction of CSS
And the other fetching tickets
WDYT?

@MICHAELMUNAVU83
Copy link
Collaborator Author

Yeah , we should have , we can divide the further upcoming tasks into smaller and smaller tasks

@MuhammadMullah
Copy link

I noticed some of the PRs are very large. I suggest having a reasonable amount of work in these PRs which makes it easier for reviewers to review and make suggestions.

Thank you

lib/elixir_conf_africa/events.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@okothkongo okothkongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a literal value; there is no need for the pin.

Could we also join on name and get rid of the where clause?

By the way, why "ElixirConf Africa 2024" can make it dynamic allowing Front End to supply us with the name?

lib/elixir_conf_africa/events.ex Outdated Show resolved Hide resolved
@okothkongo
Copy link
Collaborator

A quick one @MICHAELMUNAVU83 could also write tests that will be beneficial in the future.

If have a lot in your plate at the moment I can push some against on your branch

@okothkongo okothkongo merged commit 137f658 into main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create home styling with events and ticket types
4 participants