Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser feature link removed #202

Draft
wants to merge 4 commits into
base: staging
Choose a base branch
from
Draft

Conversation

IMPranshu
Copy link
Contributor

No description provided.

docs/index.html Outdated Show resolved Hide resolved
guides-markdown/browser.md Show resolved Hide resolved
@pinheadmz
Copy link
Member

I don't even know if this guide is still accurate. I think we removed the webpack config file at some point. Are you interested in looking in to that any further? See if you can get it working locally, even just on regtest?

@IMPranshu
Copy link
Contributor Author

I don't even know if this guide is still accurate. I think we removed the webpack config file at some point. Are you interested in looking in to that any further? See if you can get it working locally, even just on regtest?

Yes. Surely I will look into this.

@IMPranshu
Copy link
Contributor Author

I don't even know if this guide is still accurate. I think we removed the webpack config file at some point. Are you interested in looking in to that any further? See if you can get it working locally, even just on regtest?

So from what I read in the discussion in the two PR links you gave, I understood the following things:

  • webpack was removed to decrease the number of dependecies.
  • bpkg can do somewhat what webpack did.
  • It is not considered good practice to run a full node on broswer.

So the question remains Should I change the browser guide from webpack to bpkg or Shoul I remove the broswer guide and it's reference from the documentation and the website(which I think should be done ASAP)?

@Anunayj
Copy link

Anunayj commented Aug 18, 2022

I think it will be great if we can preserve the webpack guide (and perhaps update it). Changing the guide from webpack to bpkg is viable too, but I personally would prefer a webpack guide to be there (because a lot of projects use webpack for bundling, and there are some features that bpkg lacks (support for custom polyfills)).

Not to mention there are legitimate use cases of being able to bundle bcoin for browser that are not running it as a full node, something like decoding transactions in browser.

I personally found that guide quite helpful a few months ago.

@IMPranshu
Copy link
Contributor Author

I think it will be great if we can preserve the webpack guide (and perhaps update it). Changing the guide from webpack to bpkg is viable too, but I personally would prefer a webpack guide to be there (because a lot of projects use webpack for bundling, and there are some features that bpkg lacks (support for custom polyfills)).

I am tallking about this https://bcoin.io/guides/browser.html part. And it is not currently working. So leaving it up there might create confusion among new users.

Not to mention there are legitimate use cases of being able to bundle bcoin for browser that are not running it as a full node, something like decoding transactions in browser.

There are other guides for this matter available on the website like this https://bcoin.io/guides/webapp.html
But I am specifically talking about the full node in browser functionality.

@pinheadmz
Copy link
Member

There are other guides for this matter available on the website like this https://bcoin.io/guides/webapp.html But I am specifically talking about the full node in browser functionality.

That guide has bpkg directions, just copy, modify them, and replace section 1 of the browser node article. Why not keep it as long as it works ?

@IMPranshu
Copy link
Contributor Author

There are other guides for this matter available on the website like this https://bcoin.io/guides/webapp.html But I am specifically talking about the full node in browser functionality.

That guide has bpkg directions, just copy, modify them, and replace section 1 of the browser node article. Why not keep it as long as it works ?

Yeah, that will be better. I will do that and also find references for webpack in the guides and replace them with bpkg instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants