-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browser feature link removed #202
base: staging
Are you sure you want to change the base?
Conversation
repo link for cloning updated
I don't even know if this guide is still accurate. I think we removed the webpack config file at some point. Are you interested in looking in to that any further? See if you can get it working locally, even just on regtest? |
Yes. Surely I will look into this. |
So from what I read in the discussion in the two PR links you gave, I understood the following things:
So the question remains Should I change the browser guide from |
I think it will be great if we can preserve the webpack guide (and perhaps update it). Changing the guide from Not to mention there are legitimate use cases of being able to bundle bcoin for browser that are not running it as a full node, something like decoding transactions in browser. I personally found that guide quite helpful a few months ago. |
I am tallking about this https://bcoin.io/guides/browser.html part. And it is not currently working. So leaving it up there might create confusion among new users.
There are other guides for this matter available on the website like this https://bcoin.io/guides/webapp.html |
That guide has bpkg directions, just copy, modify them, and replace section 1 of the browser node article. Why not keep it as long as it works ? |
Yeah, that will be better. I will do that and also find references for |
No description provided.