Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.html #105

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Update index.html #105

wants to merge 1 commit into from

Conversation

flysteak
Copy link

Move GH STARS AND FORKS to into list area, for a better, more compact menu.

@flysteak
Update index.html
725fa6b 
Moving GH STARS AND FORKS to into list area, for a better, more compact menu.
@DarrenRM
Copy link
Collaborator

DarrenRM commented Aug 20, 2018 •
edited
Loading

Getting the GH stars and forks into the mobile menu is a great idea. I noticed a couple small issues that need some attention. I think with a few @media rules you'll be great.

  1. For widths over 991px, the buttons no longer appear vertically centered.
    image

  2. The two buttons should fit side-by-side on the same line here, with equal padding on top and bottom, to keep things compact.
    image

  • Darren

@bucko13
Copy link
Contributor

bucko13 commented Sep 6, 2018

@manufoy any chance you'd be willing to update this with the requested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flysteak @DarrenRM @bucko13