Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making workflow changes to support deployment as per 14.4.6 version #35

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

rajpalc7
Copy link
Contributor

No description provided.

@rajpalc7 rajpalc7 marked this pull request as draft January 10, 2024 18:27
@rajpalc7 rajpalc7 force-pushed the workflow branch 4 times, most recently from d171d5b to 8cb64bc Compare January 10, 2024 18:42
@rajpalc7 rajpalc7 marked this pull request as ready for review January 10, 2024 22:44
@rajpalc7 rajpalc7 requested review from WadeBarnes and esune January 10, 2024 22:44
@rajpalc7 rajpalc7 changed the title Workflow Making workflow changed to support deployment as per 14.4.6 version Jan 10, 2024
@rajpalc7 rajpalc7 changed the title Making workflow changed to support deployment as per 14.4.6 version Making workflow changes to support deployment as per 14.4.6 version Jan 10, 2024
@WadeBarnes
Copy link
Member

WadeBarnes commented Jan 11, 2024

@esune, @rajpalc7, I think we should have a meeting to review this thoroughly together. I'm also thinking we need some documentation on the setup and debugging process so we have that for reference if things ever stop working again.

@rajpalc7, I also think it's important for us to understand how you came to the resolution and what the key changes were in solving the problem.

@WadeBarnes
Copy link
Member

@rajpalc7, @esune, Is there an issue tracking the work here that we could link to?

@esune
Copy link
Member

esune commented Jan 11, 2024

@rajpalc7, @esune, Is there an issue tracking the work here that we could link to?

No, we do not have one - we can log on

@rajpalc7, @esune, Is there an issue tracking the work here that we could link to?

No, we do not have an issue - this was generated by @rajpalc7 investigating something else. We should probably log one on this repo, I guess.

@WadeBarnes
Copy link
Member

Added myself as an assignee for tracking purposes.

@rajpalc7 rajpalc7 force-pushed the workflow branch 3 times, most recently from fb826f3 to c09c399 Compare January 15, 2024 22:43
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajpalc7, Could you move the documentation up to where it has more context please.

I expected this;
image
to be placed in this section;
image
to document why the change was relevant.

@rajpalc7
Copy link
Contributor Author

rajpalc7 commented Jan 15, 2024

Thank you @WadeBarnes I have moved the documentation part as per your suggestion.

@WadeBarnes WadeBarnes merged commit 8e14077 into main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants