Skip to content

Commit

Permalink
Tracking pull request to merge release-2.17.0 to master (#2849)
Browse files Browse the repository at this point in the history
* fix: added type check for exclusion report on snapshot (#2855)

Co-authored-by: Your Name <[email protected]>

---------

Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Your Name <[email protected]>
  • Loading branch information
3 people authored Mar 22, 2024
1 parent 8abf653 commit 73f9402
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 12 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/dev-release.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
## For each release, the value of name, branches, RELEASE_NAME and PR_NUMBER need to be adjusted accordingly
## For each release, update lib/config.js: version and releaseBranch

name: TFRS Dev release-2.16.0
name: TFRS Dev release-2.17.0

on:
push:
branches: [ release-2.16.0 ]
branches: [ release-2.17.0 ]
paths:
- frontend/**
- backend/**
Expand All @@ -15,8 +15,8 @@ on:
env:
## The pull request number of the Tracking pull request to merge the release branch to main
## Also remember to update the version in .pipeline/lib/config.js
PR_NUMBER: 2836
RELEASE_NAME: release-2.16.0
PR_NUMBER: 2849
RELEASE_NAME: release-2.17.0

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tfrs-release.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## For each release, the value of name, branches, RELEASE_NAME and PR_NUMBER need to be adjusted accordingly
## For each release, update lib/config.js: version and releaseBranch

name: TFRS release-2.16.0
name: TFRS release-2.17.0

on:
workflow_dispatch:
Expand All @@ -10,8 +10,8 @@ on:
env:
## The pull request number of the Tracking pull request to merge the release branch to main
## Also remember to update the version in .pipeline/lib/config.js
PR_NUMBER: 2836
RELEASE_NAME: release-2.16.0
PR_NUMBER: 2849
RELEASE_NAME: release-2.17.0

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
4 changes: 2 additions & 2 deletions .pipeline/lib/config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const options= require('@bcgov/pipeline-cli').Util.parseArguments()
const changeId = options.pr //aka pull-request
const version = '2.16.0'
const version = '2.17.0'
const name = 'tfrs'
const ocpName = 'apps.silver.devops'

Expand All @@ -13,7 +13,7 @@ options.git.repository='tfrs'
const phases = {
build: { namespace:'0ab226-tools' , name: `${name}`, phase: 'build' , changeId:changeId, suffix: `-build-${changeId}` ,
instance: `${name}-build-${changeId}` , version:`${version}-${changeId}`, tag:`build-${version}-${changeId}`,
releaseBranch: 'release-2.16.0'
releaseBranch: 'release-2.17.0'
},
dev: {namespace:'0ab226-dev' , name: `${name}`, phase: 'dev' , changeId:changeId, suffix: `-dev` ,
instance: `${name}-dev` , version:`${version}`, tag:`dev-${version}`, dbServiceName: 'tfrs-spilo',
Expand Down
3 changes: 2 additions & 1 deletion backend/api/viewsets/ComplianceReport.py
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,8 @@ def list(self, request, *args, **kwargs):
return Response(data)

def compliance_to_new_act(self, obj, snapshot):
if int(obj.compliance_period.description) > 2022 and snapshot is not None:
if int(obj.compliance_period.description) > 2022 \
and snapshot is not None and obj.type.the_type != "Exclusion Report":
lines = snapshot.get('summary').get('lines')
if lines.get('29A') is None:
previous_transactions = []
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "tfrs",
"version": "2.16.0",
"version": "2.17.0",
"dependencies": {
"@babel/eslint-parser": "^7.19.1",
"@babel/plugin-proposal-object-rest-spread": "^7.20.7",
Expand Down
2 changes: 1 addition & 1 deletion openshift-v4/templates/backup-container-2.6.1/cronjob.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ KNP: allow CronJob to connect to Spilo
oc process -f ./db-backup-cronjob-2.6.1.yaml \
JOB_NAME=tfrs-db-backup \
JOB_PERSISTENT_STORAGE_NAME=backup \
SCHEDULE="00 07 * * *" \
SCHEDULE="00 07,21 * * *" \
TAG_NAME=2.6.1 \
DATABASE_SERVICE_NAME=tfrs-spilo-readonly \
DATABASE_DEFAULT_PORT=5432 \
Expand Down

0 comments on commit 73f9402

Please sign in to comment.