fix: deletion limit #385
Merged
fix: deletion limit #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jlangy
commented
Sep 20, 2024
•
jlangy
commented
- Fix delete limit going slightly over
- Switch to BCeID Web Service (kept the function for ms graph so we can switch back easily if needed)
- Changed the limit in prod from 250 total (50 in 5 runners) to 50 in total (10 in 5 runners), open to discussion on that being too low I think we rarely see more than 50 in a night though, and it would just catch up the next day if there are more
fix limit to also break from the batch loop
jlangy
requested review from
NithinKuruba,
thegentlemanphysicist and
arcshiftsolutions
as code owners
add back bceid user check
bump max deletions to 30 per runner
NithinKuruba
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.