24936 - Product and Services tab update #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
reviewed
Jan 2, 2025
| @@ -889,6 +891,17 @@ export const useOrgStore = defineStore('org', () => { | |||
| return [] | |||
| } | |||
|
|
|||
| async function getProductPaymentMethods (productCode?: string | undefined): Promise<any> { | |||
| const response: any = await CodesService.getPaymentMethods(productCode || undefined) | |||
| if (response?.data && response.status === 200) { | |||
There was a problem hiding this comment.
Should move this to service, store doesn't really care about the status?
store just cares about the data?
seeker25
reviewed
Jan 2, 2025
| @@ -7,4 +7,11 @@ export default class CodesService { | |||
| public static async getCodes (codeType: string): Promise<AxiosResponse<Code[]>> { | |||
| return axios.get(`${ConfigHelper.getAuthAPIUrl()}/codes/${codeType}`) | |||
| } | |||
|
|
|||
| public static async getPaymentMethods (productCode?: string): Promise<AxiosResponse<{[key: string]: string[]}>> { | |||
| const url = productCode | |||
There was a problem hiding this comment.
const baseUrl = ${ConfigHelper.getPayAPIURL()}/codes/valid_payment_methods;
const url = productCode ? ${baseUrl}/${productCode} : baseUrl;
return axios.get(url);
seeker25
reviewed
Jan 2, 2025
| @@ -34,6 +26,7 @@ | |||
| :productDetails="product" | |||
| :isexpandedView="product.code === expandedProductCode" | |||
| :isSelected="currentSelectedProducts.includes(product.code)" | |||
| :paymentMethods="productPaymentMethods[product.code === 'BUSINESS_SEARCH' ? 'BUSINESSSearch' : product.code] || []" | |||
seeker25
reviewed
Jan 2, 2025
|
seeker25
merged commit 9f5a259
into
bcgov:feature-remove-account-type
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#24936
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).