24920 - Redirect to new BRD based on FF and Query Param #3192
Conversation
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3192-2mpoe0is.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3192-2mpoe0is.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3192-2mpoe0is.web.app Should redirect: https://bcregistry-account-dev--pr-3192-2mpoe0is.web.app/account/3040/business |
|
While you're here, I noticed this console error:
I believe the new URL is gold, not silver. Please update the example, and your, env file. |
|
One last thing: when you merge this, please let developers know that from now on, they'll be using the new BRD (and tell them about the query parameter to not redirect, if they need it -- or point them to this PR). |
Deal, will do. |
|
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "auth-web", | |||
| "version": "2.6.128", | |||
| "version": "2.7.0", | |||
| @@ -229,6 +230,13 @@ export function getRoutes (): RouteConfig[] { | |||
| { | |||
| path: '/account/:orgId', | |||
| name: 'account', | |||
| beforeEnter: (to, from, next) => { | |||
| if (LaunchDarklyService.getFlag(LDFlags.EnableBusinessRegistryDashboard) && !to.query.noRedirect) { | |||
| window.location.href = ConfigHelper.getNewBusinessRegistryDashboardUrl() | |||
There was a problem hiding this comment.
I wonder if this should return a new route (instead of hard-overwriting the URL like this)? That way, it could maybe retain the URL query parameters (eg, account id)...?
Ref: https://router.vuejs.org/guide/advanced/navigation-guards.html#Per-Route-Guard
There was a problem hiding this comment.
That's the plan 👍
Issue #:
bcgov/entity#24920
Description of changes:
enable-business-registry-dashboardand if the Query Paramnewbrdis true.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).