24363 - New magic link formatting based if FF is on #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JazzarKarim
commented
Dec 3, 2024
| escape_url = escape_wam_friendly_url(org_name) | ||
| path = f"{escape_url}/affiliationInvitation/acceptToken" | ||
| token_confirm_url = f"{app_url}/{path}/{token}" | ||
| if flags.is_on("enable-new-magic-link-formatting-with-query-params", default=False): |
There was a problem hiding this comment.
Travis, can you add this FF to LD please?
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3166-ej0e620z.web.app |
seeker25
approved these changes
Dec 3, 2024
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#24363
Description of changes:
Magic link now uses query params. The new format is more standard and easier to parse since all variables are consistently passed as query parameters rather than being embedded in the URL path.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).