Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding volumes to caddy #2177

Merged
merged 1 commit into from
Nov 24, 2024
Merged

feat: adding volumes to caddy #2177

merged 1 commit into from
Nov 24, 2024

Conversation

mishraomp
Copy link
Collaborator

@mishraomp mishraomp commented Nov 24, 2024


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mishraomp
Copy link
Collaborator Author

mishraomp commented Nov 24, 2024

This PR, gets rid of these errors @DerekRoberts

{"level":"error","ts":1731721570.8650506,"msg":"unable to autosave config","file":"/config/caddy/autosave.json","error":"open /config/caddy/autosave.json: permission denied"}
{"level":"info","ts":1731721570.8650634,"msg":"serving initial configuration"}
{"level":"warn","ts":1731721570.865168,"logger":"tls","msg":"unable to get instance ID; storage clean stamps will be incomplete","error":"open /data/caddy/instance.uuid: permission denied"}
{"level":"error","ts":1731721570.8652291,"logger":"tls","msg":"could not clean default/global storage","error":"unable to acquire storage_clean lock: creating lock file: open /data/caddy/locks/storage_clean.lock: no such file or directory"}
{"level":"info","ts":1731721570.865238,"logger":"tls","msg":"finished cleaning storage units"}

after this PR

{"level":"info","ts":1732480126.9838376,"msg":"autosaved config (load with --resume flag)","file":"/config/caddy/autosave.json"}
{"level":"info","ts":1732480126.983847,"msg":"serving initial configuration"}
{"level":"info","ts":1732480126.9847589,"logger":"tls","msg":"cleaning storage unit","storage":"FileStorage:/data/caddy"}
{"level":"info","ts":1732480126.9848661,"logger":"tls","msg":"finished cleaning storage units"}

Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvement! Much better than ignoring warnings. :)

@mishraomp mishraomp merged commit 9d0c9f8 into main Nov 24, 2024
24 checks passed
@mishraomp mishraomp deleted the feat/caddy-pvc-temp branch November 24, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants