Skip to content

Commit

Permalink
fix: autoscaling and secrets
Browse files Browse the repository at this point in the history
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
  • Loading branch information
mishraomp committed Mar 6, 2024
1 parent e28fc5d commit 56c5b50
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
params:
--set backend.deploymentStrategy=RollingUpdate
--set frontend.deploymentStrategy=RollingUpdate

--set global.autoscaling=true
promote:
name: Promote Images
needs: [deploy-prod, vars]
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr-open.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ jobs:
oc_token: ${{ secrets.OC_TOKEN }}
with:
triggers: ('backend/', 'frontend/', 'migrations/')

params:
--set global.secrets.persist=false
tests:
name: Tests
needs: [deploys]
Expand Down
5 changes: 4 additions & 1 deletion charts/app/templates/secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ apiVersion: v1
kind: Secret
metadata:
name: {{ .Release.Name }}
labels: {{- include "selectorLabels" . | nindent 4 }}
labels: {{- include "labels" . | nindent 4 }}
{{-if .Values.global.secrets.persist }}
"helm.sh/resource-policy": keep
{{- end }}

data:
databasePassword: {{ $databasePassword | quote }}
postgres-password: {{ $databasePassword | quote }}
Expand Down
3 changes: 1 addition & 2 deletions charts/app/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ global:
databasePassword: ~
databaseUser: ~
databaseName: ~
annotation:
helm.sh/policy: "keep"
persist: true
#-- domain of the application, it is required, apps.silver.devops.gov.bc.ca for silver cluster and apps.devops.gov.bc.ca for gold cluster
domain: "apps.silver.devops.gov.bc.ca" # it is apps.gold.devops.gov.bc.ca for gold cluster
#-- the database Alias gives a nice way to switch to different databases, crunchy, patroni ... etc.
Expand Down

0 comments on commit 56c5b50

Please sign in to comment.