Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: janky cron to avoid asterisks #67

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: janky cron to avoid asterisks #67

merged 1 commit into from
Dec 19, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Dec 19, 2023

Templates with asterisks (*) have been expanding improperly. I'm struggling to escape this cleanly and have sidestepped the issue with ranges. They're ugly, but easy enough to understand and manage.

e.g. schedule: "${CRON_MINUTES} 8 1-31 1-12 0-6"


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@DerekRoberts DerekRoberts self-assigned this Dec 19, 2023
@DerekRoberts DerekRoberts added the bug Something isn't working label Dec 19, 2023
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishraomp mishraomp merged commit bba47c8 into main Dec 19, 2023
20 checks passed
@mishraomp mishraomp deleted the bug/templateCron branch December 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants