-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove flyway as init container and deploy it as a separate task #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this SO MUCH better! Transparency. Great job. :)
I think we should port it back to quickstart openshift, and run flyway as a job during rollout to avoid init container, and api rollout will depend on flyway rollout, thoughts? |
Agreed. The challenge is how to structure that for k8s where init pattern, which I hate, is the recommended path. Deployments are generally supposed to happen simultaneously. |
Well, should. We're going to deviate! |
currently. flyway is deployed as init container. it works but impacts auto scaling as it takes around a minute(image pulling, scheduling et..) for flyway container to be provisioned and complete.
this change would remove flyway from init container and will only execute during rollout.
this will make sure that when autoscaler kicks in it is only executing node api container and ready to server incoming traffic within 10 to 20 seconds.
successful deployment: https://github.com/bcgov/quickstart-aws-containers/actions/runs/12437101568/job/34726315097
and flyway task is executed successfully.
here is the sample that it takes around a minute