Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ORV2-1679 - Update payment methods for refund and payment on frontend #767

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Nov 21, 2023

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Update payment method and card type usage for payment and refund related logic and pages

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check that all payment and refund related functionalities (for amend/void/revoke) work as expected.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@zgong-gov zgong-gov changed the title ORV2-1679 ORV2-1679: feat - Update payment methods for refund and payment on frontend Nov 21, 2023
@zgong-gov zgong-gov changed the title ORV2-1679: feat - Update payment methods for refund and payment on frontend feat: ORV2-1679 - Update payment methods for refund and payment on frontend Nov 21, 2023
@erikataot
Copy link
Contributor

with regards to working with money in JavaScript, I've found this lib really helps keeping the precision when working with money and currencies - https://mikemcl.github.io/decimal.js/

erikataot
erikataot previously approved these changes Nov 21, 2023
@erikataot erikataot dismissed their stale review November 21, 2023 19:30

more changes coming

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@praju-aot praju-aot merged commit 4ea8e14 into main Nov 21, 2023
15 checks passed
@praju-aot praju-aot deleted the ORV2-1679 branch November 21, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants