Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-1632 Some UI Cleanup #730

Merged
merged 3 commits into from
Nov 14, 2023
Merged

ORV2-1632 Some UI Cleanup #730

merged 3 commits into from
Nov 14, 2023

Conversation

erikataot
Copy link
Contributor

@erikataot erikataot commented Nov 14, 2023

Description

  • Cleaned up some UX by removing the Filter, Copy and CSV Options from the Vehicles tables (to match the Permits)
  • Updated the Vehicle, Trailers, and Active Permits tables to standardize the No Records to Display rendering
    (Wish you could hide the whole table, but MRT doesn't support that)

Screenshot 2023-11-14 113100

Screenshot 2023-11-14 113112

Screenshot 2023-11-14 113123

Fixes # (issue) https://jira.th.gov.bc.ca/browse/ORV2-1632

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erikataot erikataot merged commit 554116e into main Nov 14, 2023
16 checks passed
@erikataot erikataot deleted the ORV2-1632-some-UI-cleanup branch November 14, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants