Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-1390 Puppetteer experiment #683

Closed
wants to merge 15 commits into from
Closed

ORV2-1390 Puppetteer experiment #683

wants to merge 15 commits into from

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Oct 23, 2023 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2023
View reviewed changes
backend/dops/Dockerfile
@@ -1,32 +1,68 @@
# Build container
FROM node:18.17.1-alpine AS builder
FROM ubuntu:latest as builder

Check warning

Code scanning / Trivy

':latest' tag used Medium

Artifact: backend/dops/Dockerfile
Type: dockerfile
Vulnerability DS001
Severity: MEDIUM
Message: Specify a tag in the 'FROM' statement for image 'ubuntu'
Link: DS001
backend/dops/Dockerfile
Comment on lines +38 to +40
RUN wget --no-verbose -O /tmp/chrome.deb https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_${CHROME_VERSION}_amd64.deb \
&& apt install -y /tmp/chrome.deb \
&& rm /tmp/chrome.deb

Check notice

Code scanning / Trivy

RUN using 'wget' and 'curl' Low

Artifact: backend/dops/Dockerfile
Type: dockerfile
Vulnerability DS014
Severity: LOW
Message: Shouldn't use both curl and wget
Link: DS014
backend/dops/Dockerfile
FROM ubuntu:latest as builder


RUN apt-get update

Check failure

Code scanning / Trivy

'RUN <package-manager> update' instruction alone High

Artifact: backend/dops/Dockerfile
Type: dockerfile
Vulnerability DS017
Severity: HIGH
Message: The instruction 'RUN update' should always be followed by ' install' in the same RUN statement.
Link: DS017
backend/dops/Dockerfile
Comment on lines +20 to +27
RUN apt-get install -y gconf-service libasound2 libatk1.0-0 libc6 \
libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 \
libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 \
libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 \
libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 \
libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates \
fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils \
wget libgbm-dev gnupg gnupg2 gnupg1

Check failure

Code scanning / Trivy

'apt-get' missing '--no-install-recommends' High

Artifact: backend/dops/Dockerfile
Type: dockerfile
Vulnerability DS029
Severity: HIGH
Message: '--no-install-recommends' flag is missed: 'apt-get install -y gconf-service libasound2 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget libgbm-dev gnupg gnupg2 gnupg1'
Link: DS029
@praju-aot praju-aot temporarily deployed to dev October 23, 2023 18:48 — with GitHub Actions Inactive
@cberg-aot cberg-aot temporarily deployed to dev October 23, 2023 19:24 — with GitHub Actions Inactive
@cberg-aot cberg-aot temporarily deployed to dev October 23, 2023 19:38 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 23, 2023 20:15 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 23, 2023 20:24 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2023
View reviewed changes
backend/dops/Dockerfile Fixed Show fixed Hide fixed
@praju-aot praju-aot temporarily deployed to dev October 23, 2023 22:18 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 23, 2023 23:33 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 23, 2023 23:45 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 10 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@praju-aot praju-aot temporarily deployed to dev October 23, 2023 23:56 — with GitHub Actions Inactive
@praju-aot praju-aot closed this Oct 24, 2023
@praju-aot praju-aot temporarily deployed to dev October 24, 2023 00:06 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 24, 2023 00:06 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 24, 2023 00:06 — with GitHub Actions Inactive
@cberg-aot cberg-aot temporarily deployed to dev October 26, 2023 23:54 — with GitHub Actions Inactive
@cberg-aot cberg-aot temporarily deployed to dev October 26, 2023 23:54 — with GitHub Actions Inactive
@cberg-aot cberg-aot temporarily deployed to dev October 26, 2023 23:54 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cberg-aot cberg-aot Awaiting requested review from cberg-aot cberg-aot is a code owner

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praju-aot @cberg-aot