Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-1463 Rename DB table and cols to meet MOTI recommendations #668

Merged
merged 7 commits into from
Oct 4, 2023
Merged

ORV2-1463 Rename DB table and cols to meet MOTI recommendations #668

merged 7 commits into from
Oct 4, 2023

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Sep 29, 2023 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Rename DB table and cols to meet MOTI recommendations
ORBC_VT_COUNTRY -> ORBC_COUNTRY_TYPE
ORBC_VT_PROVINCE -> ORBC_PROVINCE_TYPE
ORBC_VT_PAYMENT_METHOD -> ORBC_PAYMENT_METHOD_TYPE
ORBC_VT_PERMIT_APPLICATION_ORIGIN -> ORBC_PERMIT_APPLICATION_ORIGIN_TYPE
ORBC_VT_PERMIT_APPROVAL_SOURCE -> ORBC_PERMIT_APPROVAL_SOURCE_TYPE
ORBC_VT_PERMIT_TYPE -> ORBC_PERMIT_TYPE
ORBC_VT_POWER_UNIT_TYPE -> ORBC_POWER_UNIT_TYPE
ORBC_VT_TRAILER_TYPE -> ORBC_TRAILER_TYPE

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • docker
  • Manual api testing

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@praju-aot praju-aot temporarily deployed to dev September 29, 2023 16:49 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev September 29, 2023 16:49 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev September 29, 2023 16:54 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev September 29, 2023 16:54 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev September 29, 2023 16:54 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev September 29, 2023 16:54 — with GitHub Actions Inactive
john-fletcher-aot
john-fletcher-aot approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested from DB side and all works as expected

gchauhan-aot
gchauhan-aot previously approved these changes Sep 29, 2023
View reviewed changes
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 16:31 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 16:31 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 16:49 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 16:49 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 16:49 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 17:03 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 17:03 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 17:03 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 17:03 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 4, 2023 18:59 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@DerekRoberts DerekRoberts temporarily deployed to dev October 4, 2023 22:37 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev October 4, 2023 22:37 — with GitHub Actions Inactive
@DerekRoberts DerekRoberts temporarily deployed to dev October 4, 2023 22:37 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot merged commit 8bdfb32 into main Oct 4, 2023
15 of 16 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-1463 branch October 4, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchauhan-aot gchauhan-aot gchauhan-aot approved these changes

@john-fletcher-aot john-fletcher-aot john-fletcher-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praju-aot @john-fletcher-aot @gchauhan-aot @DerekRoberts