Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for LCV in latest policy engine version #1720

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Dec 24, 2024

Description

Update the policy configuration JSON with a new version insert into the policy configuration table. The new policy configuration JSON adds an 'isLcv' flag for the long combination vehicle definitions, which is used by the new policy engine version during validation and STOS vehicle configurations.

Also updates the npm package version of onroute-policy-engine in frontend.

Fixes # ORV2-3160

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Policy engine tested with this configuration with unit tests in policy engine repository
  • Tested the database version in sql docker container, confirmed no errors
  • Verified in SSMS with sql docker container that the new policy configuration inserts correctly

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

Copy link

Copy link

Copy link

Copy link

@john-fletcher-aot john-fletcher-aot merged commit f7fb115 into main Dec 24, 2024
24 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-3160 branch December 24, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants