-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1610 notification for greyed out submission button #1747
feat: 1610 notification for greyed out submission button #1747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mgaseta I tested the front end and the banner is showing up as expected when the form is not fully completed. During testing, I tried completing a seedlot registration so that I could also test when happens when all the fields are correctly entered. I found that the ownership section seemed to be locked out on me. I'm not sure where this issue is coming from, but could you please investigate before merging? I've provided a video of my testing session here for you to see: [https://bcgov.sharepoint.com/:v:/r/teams/07176/Shared%20Documents/General/SPAR%20Testing/1747testing.mp4?csf=1&web=1&e=wnh6gE](https://bcgov.sharepoint.com/:v:/r/teams/07176/Shared%20Documents/General/SPAR%20Testing/%5B1747testing.mp4%5D(https://bcgov.sharepoint.com/:v:/r/teams/07176/Shared%20Documents/General/SPAR%20Testing/1747testing.mp4?csf=1&web=1&e=wnh6gE)?csf=1&web=1&e=wnh6gE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ownership issue is not present in prod or previous PR's. I found that issue while testing on this branch.
…' of github.com:bcgov/nr-spar into feat/1610-notification-for-greyed-out-submission-button
…' of github.com:bcgov/nr-spar into feat/1610-notification-for-greyed-out-submission-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the FE and the ownership section stuff is fixed in dev :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ownership issue fixed, LGTM 😎
Description
Closes #1610
Changelog
New
Changed
Removed
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: