Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1610 notification for greyed out submission button #1747

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

mgaseta
Copy link
Collaborator

@mgaseta mgaseta commented Nov 22, 2024

Description

Closes #1610

Changelog

New

  • Added new banner to seedlot registration

Changed

  • Nothing :)

Removed

  • Nothing :)

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta requested a review from ngunner15 November 22, 2024 20:25
@mgaseta mgaseta self-assigned this Nov 22, 2024
@mgaseta mgaseta linked an issue Nov 22, 2024 that may be closed by this pull request
8 tasks
Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@SLDonnelly SLDonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mgaseta I tested the front end and the banner is showing up as expected when the form is not fully completed. During testing, I tried completing a seedlot registration so that I could also test when happens when all the fields are correctly entered. I found that the ownership section seemed to be locked out on me. I'm not sure where this issue is coming from, but could you please investigate before merging? I've provided a video of my testing session here for you to see: [https://bcgov.sharepoint.com/:v:/r/teams/07176/Shared%20Documents/General/SPAR%20Testing/1747testing.mp4?csf=1&web=1&e=wnh6gE](https://bcgov.sharepoint.com/:v:/r/teams/07176/Shared%20Documents/General/SPAR%20Testing/%5B1747testing.mp4%5D(https://bcgov.sharepoint.com/:v:/r/teams/07176/Shared%20Documents/General/SPAR%20Testing/1747testing.mp4?csf=1&web=1&e=wnh6gE)?csf=1&web=1&e=wnh6gE)

Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ownership issue is not present in prod or previous PR's. I found that issue while testing on this branch.

@mgaseta mgaseta closed this Dec 5, 2024
@mgaseta mgaseta reopened this Dec 5, 2024
@mgaseta mgaseta closed this Dec 5, 2024
@mgaseta mgaseta reopened this Dec 5, 2024
…' of github.com:bcgov/nr-spar into feat/1610-notification-for-greyed-out-submission-button
Copy link
Collaborator

@SLDonnelly SLDonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the FE and the ownership section stuff is fixed in dev :)

Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership issue fixed, LGTM 😎

@mgaseta mgaseta merged commit 1f465c1 into main Dec 10, 2024
28 of 29 checks passed
@mgaseta mgaseta deleted the feat/1610-notification-for-greyed-out-submission-button branch December 10, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification for greyed out submission button
4 participants