generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SILVA-502): fixing map on silviculture search screen #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted the polygon generation to a new component - Updated the map component - Updated the silviculture components
paulushcgcj
requested review from
carolinemwood,
jazzgrewal,
DerekRoberts and
gpascucci
as code owners
November 18, 2024 14:04
This will allow the user to interact with the checkbox or action without a modal
This pull request contains some uncovered code that can only be tested when mounting the entire DOM. For it to work properly, we will need to set up Cypress. This will be done in a separate PR as it is out of the scope of this one. |
DerekRoberts
approved these changes
Nov 18, 2024
jazzgrewal
pushed a commit
that referenced
this pull request
Nov 18, 2024
paulushcgcj
added a commit
that referenced
this pull request
Nov 19, 2024
DerekRoberts
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed map on silviculture screen. Added the ability to select multiple entries
Type of change
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-472-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-22-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow