Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-502): fixing map on silviculture search screen #472

Merged
merged 13 commits into from
Nov 18, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 18, 2024

Description

Fixed map on silviculture screen. Added the ability to select multiple entries

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-472-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-22-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@paulushcgcj
Copy link
Contributor Author

This pull request contains some uncovered code that can only be tested when mounting the entire DOM. For it to work properly, we will need to set up Cypress. This will be done in a separate PR as it is out of the scope of this one.

@paulushcgcj paulushcgcj merged commit 5612b3c into main Nov 18, 2024
18 of 19 checks passed
@paulushcgcj paulushcgcj deleted the fix/SILVA-502 branch November 18, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants