fix(SILVA-558): opening details prompt modal #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzgrewal
requested review from
carolinemwood,
paulushcgcj,
DerekRoberts and
gpascucci
as code owners
paulushcgcj
changed the title
paulushcgcj
changed the title
paulushcgcj
approved these changes
Nov 18, 2024
DerekRoberts
added a commit
that referenced
this pull request
Nov 19, 2024
This reverts commit 5f3a165.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update modifies the modal text shown when users click on an Opening ID in the OpeningSearchTable. The modal now provides a message informing users that the opening details page is still under development and directs them to the legacy system for more information.
Changes:
When a user clicks on an Opening ID, the modal will now display the following message:
**"Coming Soon
An opening details page is in development.
Until it's available, search for [Opening ID] in RESULTS to view the opening details."**
This update ensures users are informed about the current status of the opening details feature and provides a clear alternative to access the information.
Additional Changes:
This PR also includes the addition of a unit test for the modal component, ensuring that the updated text is displayed correctly when an Opening ID is clicked.
Why this is being done:
The opening details page is still in development, and this modal provides users with a clear message while managing their expectations.
Directing users to the legacy RESULTS application will ensure they can still access the information they need while the new feature is being finalized.
The unit test ensures that the modal behaves as expected and displays the correct message when triggered.
Testing:
Verify that clicking on an Opening ID in the OpeningSearchTable triggers the modal.
Confirm that the modal displays the new text:
"Coming Soon
An opening details page is in development.
Until it's available, search for [Opening ID] in RESULTS to view the opening details."
Ensure the unit test properly validates that the modal text is rendered correctly.
Test the component across multiple browsers and devices to ensure consistent behavior.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-471-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-21-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow