Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-536): fixing missing notification when no param provided #461

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 12, 2024

Description

Added a message to notify the user in case no parameter was provided and prevented the search from happening if no parameter was provided.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-461-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-11-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@paulushcgcj paulushcgcj marked this pull request as ready for review November 12, 2024 21:51
@paulushcgcj
Copy link
Contributor Author

Approved by Nanda

@paulushcgcj paulushcgcj enabled auto-merge (squash) November 13, 2024 01:47
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. :)

@paulushcgcj paulushcgcj merged commit cdee258 into main Nov 13, 2024
19 checks passed
@paulushcgcj paulushcgcj deleted the fix/SILVA-536 branch November 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants