Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SILVA-566): close advanced search when user click on search #459

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix(SILVA-566): close advanced search when user click on search #459

merged 2 commits into from
Nov 12, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 12, 2024 •
edited by github-actions bot
Loading

Description

Closed the advanced search dropdown when user clicks on search button

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-459-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-9-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@paulushcgcj
Copy link
Contributor Author

Approved by Nanda

@paulushcgcj paulushcgcj marked this pull request as ready for review November 12, 2024 19:15
@paulushcgcj paulushcgcj enabled auto-merge (squash) November 12, 2024 21:27
@paulushcgcj paulushcgcj merged commit c4a53e4 into main Nov 12, 2024
22 of 23 checks passed
@paulushcgcj paulushcgcj deleted the fix/SILVA-566 branch November 12, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@carolinemwood carolinemwood Awaiting requested review from carolinemwood carolinemwood is a code owner

@jazzgrewal jazzgrewal Awaiting requested review from jazzgrewal jazzgrewal is a code owner

@gpascucci gpascucci Awaiting requested review from gpascucci gpascucci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @DerekRoberts