Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-550): Enhance Org Unit and Category Selection with Filterable Multi-Select Dropdown #442

Merged
merged 15 commits into from
Nov 6, 2024

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Nov 4, 2024

Description

This PR addresses the limitations of the current "Org unit" and "Category" dropdowns by replacing them with a filterable multi-select dropdown component. This change improves user interaction by allowing users to easily filter options and select multiple items simultaneously. This involves changes in both the frontend and the backend of the application.
Fixes # (SILVA-550)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested Locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-442-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-42-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed for 'nr-silva-frontend'

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Nov 5, 2024

@paulushcgcj paulushcgcj changed the title Enhance Org Unit and Category Selection with Filterable Multi-Select Dropdown fix(SILVA-550): Enhance Org Unit and Category Selection with Filterable Multi-Select Dropdown Nov 5, 2024
@jazzgrewal jazzgrewal merged commit 813f231 into main Nov 6, 2024
19 checks passed
@jazzgrewal jazzgrewal deleted the fix/multiSelectOpeningSearchFeatures branch November 6, 2024 23:59
jazzgrewal added a commit that referenced this pull request Nov 7, 2024
…le Multi-Select Dropdown (#442)

Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants