-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SILVA-546): fixing amplify authentication #441
Conversation
Removed code that is not used or became irrelevant
- Post login was just causing confusion - Protected route is now a parent handler for routes
- simplified the class to be more streamlined
- code was too complex - no org selection is required for soft launch
Simplified code and added e2e test capability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality Gate passed for 'nr-silva-frontend'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, works great now!
Description
There was an issue related to Amplify that was losing track of the current user session after the page was refreshed. To fix that, I'm refactoring the frontend code to make the authentication handling more streamlined and match the expected react format.
I also removed some code that was not necessary for now
Type of change
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-441-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-41-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow