Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-546): fixing amplify authentication #441

Merged
merged 37 commits into from
Nov 4, 2024
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 1, 2024

Description

There was an issue related to Amplify that was losing track of the current user session after the page was refreshed. To fix that, I'm refactoring the frontend code to make the authentication handling more streamlined and match the expected react format.

I also removed some code that was not necessary for now

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-441-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-41-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@paulushcgcj paulushcgcj marked this pull request as ready for review November 4, 2024 13:18
@paulushcgcj paulushcgcj enabled auto-merge (squash) November 4, 2024 18:15
Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application does not load in the PR link:
image
Get the error, most likely failing to load the env variable for the clientId or something related to cognito.

@paulushcgcj
Copy link
Contributor Author

The application does not load in the PR link: image Get the error, most likely failing to load the env variable for the clientId or something related to cognito.

Exactly, it is because I removed some hardcoded values from the application.

Copy link

sonarqubecloud bot commented Nov 4, 2024

Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works great now!

@paulushcgcj paulushcgcj disabled auto-merge November 4, 2024 19:21
@paulushcgcj paulushcgcj merged commit ded58d0 into main Nov 4, 2024
18 checks passed
@paulushcgcj paulushcgcj deleted the fix/SILVA-546 branch November 4, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants