Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updating tests and some code refactor #428

Merged
merged 17 commits into from
Oct 29, 2024
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 29, 2024

Description

Code refactor and test update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-428-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-28-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! My favourite tests are the ones that keep working. :D

@paulushcgcj paulushcgcj enabled auto-merge (squash) October 29, 2024 16:16
@paulushcgcj paulushcgcj merged commit 1eb273a into main Oct 29, 2024
16 checks passed
@paulushcgcj paulushcgcj deleted the chore/code-refactor-8 branch October 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants