-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SILVA-514): adding favorite function on the backend #423
Conversation
Small code refactor to change some dependencies
Swagger is not required for the backend api as the only consumer should be the frontend app
Quality Gate failed for 'nr-silva-frontend'Failed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Quality Gate passed for 'results'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a massive change and i must admit it was overwhelming to review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat Job!
Description
Rework on the favorite function on the backend to manage favorite openings
Type of change
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-423-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-23-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow