Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SILVA-514): adding favorite function on the backend #423

Merged
merged 44 commits into from
Nov 6, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 28, 2024

Description

Rework on the favorite function on the backend to manage favorite openings

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-423-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-23-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Small code refactor to change some dependencies
Swagger is not required for the backend api as the only consumer should be the frontend app
@paulushcgcj paulushcgcj marked this pull request as ready for review November 5, 2024 13:06
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed for 'nr-silva-frontend'

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Collaborator

@gpascucci gpascucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a massive change and i must admit it was overwhelming to review!

Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat Job!

@paulushcgcj paulushcgcj merged commit 290c1c0 into main Nov 6, 2024
19 checks passed
@paulushcgcj paulushcgcj deleted the feat/SILVA-514 branch November 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants