Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code refactor - removing swagger #418

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 28, 2024

Description

Swagger is not required for the backend api as the only consumer should be the frontend app

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-418-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-18-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Small code refactor to change some dependencies
Swagger is not required for the backend api as the only consumer should be the frontend app
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't like Swagger anymore? I'm going to have questions about this one!

@paulushcgcj paulushcgcj enabled auto-merge (squash) October 28, 2024 14:48
@paulushcgcj paulushcgcj disabled auto-merge October 28, 2024 14:59
@paulushcgcj paulushcgcj merged commit 6014d4b into main Oct 28, 2024
15 of 16 checks passed
@paulushcgcj paulushcgcj deleted the chore/code-refactor-2 branch October 28, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants