-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/opening search #365
Feat/opening search #365
Conversation
Mergin the main to the feat/openingSearch
…eat/openingSearch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Jazz!! That's huge! 👏🏻
I left some questions and some issues to look at. We can discuss them if you want.
frontend/src/components/SilvicultureSearch/Openings/AdvancedSearchDropdown/index copy.tsx
Outdated
Show resolved
Hide resolved
A couple of more notes:
|
|
Closing/reopening to troubleshoot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get this merged. I need these changes to get my tasks done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! :)
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (390)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-365-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-15-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow