Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/opening search #365

Merged
merged 61 commits into from
Oct 8, 2024
Merged

Feat/opening search #365

merged 61 commits into from
Oct 8, 2024

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Sep 5, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (390)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Docker Compose Locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-365-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-15-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Jazz!! That's huge! 👏🏻

I left some questions and some issues to look at. We can discuss them if you want.

@RMCampos
Copy link

A couple of more notes:

  • Pre-load category and org unit, so when users open up the advanced search, they don't need to wait for the load;
  • Put the two checkbox in the top left in a single line (opening created by and section 108)
  • Display CODE + DESCRIPTION for the Category and Org Unit
  • I'll update the Org Unit API for the backend responding with only 23 records
  • Remove Block status combonox from the advanves search
  • Change the label from Block Statuses to Status and put all the statuses in one line.
  • Remove status from the bottom left, the status is already displayed at the right, in the checkboxes

@jazzgrewal
Copy link
Collaborator Author

A couple of more notes:

  • Pre-load category and org unit, so when users open up the advanced search, they don't need to wait for the load; Both the drop-down are already being pre-populated but it might seem slow only because the org-unit response is huge.
  • Put the two checkbox in the top left in a single line (opening created by and section 108) : done
  • Display CODE + DESCRIPTION for the Category and Org Unit : done , but not sure if the StatusTag wiull get too long, so just put the description for now.
  • I'll update the Org Unit API for the backend responding with only 23 records : great thanks
  • Remove Block status combonox from the advanves search : done
  • Change the label from Block Statuses to Status and put all the statuses in one line. changed, but putting all in one line might change the design proposed by nanda.
  • Remove status from the bottom left, the status is already displayed at the right, in the checkboxes: done

@DerekRoberts DerekRoberts reopened this Oct 1, 2024
@DerekRoberts
Copy link
Member

Closing/reopening to troubleshoot.

@RMCampos RMCampos self-requested a review October 8, 2024 15:57
Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get this merged. I need these changes to get my tasks done :)

@jazzgrewal jazzgrewal marked this pull request as ready for review October 8, 2024 22:22
frontend/package-lock.json Fixed Show resolved Hide resolved
frontend/package-lock.json Fixed Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
frontend/src/components/OpeningsSearchTable/testData.ts Outdated Show resolved Hide resolved
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@jazzgrewal jazzgrewal merged commit 48ddce2 into main Oct 8, 2024
16 checks passed
@jazzgrewal jazzgrewal deleted the feat/openingSearch branch October 8, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants